Should one major in what he is good at or what offers more money in the future

I am a professor. I have seen many students choose a major they are not good at. Sometimes it is for the money. Sometimes it is because they think the career will be "cool" but they do not understand what kind of preparation they need. Sometimes it is due to parental pressure. Sometimes it is due to restrictions put on them in order to qualify for a particular scholarship.

And often, I have seen these students flunk out of college.

You won't benefit from a field that pays well if you never actually qualify to get a job in that field.

“Love what you do and you will never have to work a day in your life.”

It really depends on what you want out of life. If money is more important than happiness, or if money IS your happiness then yes choose whatever career path will pay the most. There could be that middle path too where you earn relatively ok money doing something you somewhat enjoy. Then you kind of get the best of both worlds.

Do what you're good at, or what you enjoy. If you like horses, shoveling shit is a walk in the park if it pays the bills. Just saying.😁

All the money in the world is worthless if one is miserable.

If you perform poorly at your job I wouldn’t see how you’d be able to continue doing it for long. But the detail of income can’t be ignored either. Life certainly can be expensive & worrying if you don’t have enough for the things you need or eventually want it could be negative.