Should all singers play or learn the piano?

It definitely helps. I sing backup and because I played piano a bit, I find that it becomes easier to "hear" the missing note in my head. Being able to recognize intervals like 3rds or 5ths helps a ton.