Why is it controversial to suggest that someone who is a member of a foreign military should not hold public office in the United States?

It's not controversial and it should not be allowed out of an abundance of caution. If someone is engaged in foreign military efforts, they can't extend their unbiased loyalty to the USA (or any host country for that matter). That's just common sense.