I need advice, would it be bad to ask your longtime girlfriend her ring size?

Not if your doing it just because you think it's what you're supposed to do. You should get married if that is what you both want.