When is a sense of humor attractive..wheni is it not?

Generally, I think a sense of humor stops being attractive when the humor is about things that are considered gross or taboo. Dark humor and toilet humor can be effective, but they're not going to win much booty.