Is there always a silver lining in challenging times?

Almost always. Unless you have deliberately placed yourself repeatedly in the same awful situation. Sometimes the lessons have been learned and the only thing left to gain is you becoming tired of living that way.