What do you think of people who always threaten suicide when they face adversity?

Depends on the person. Some use it as a manipulation tactic, and some are being genuine. Both should try to work through the problem and seek help as needed, of course, but it's really on a person to person basis